fix(Android): Change implementation of headerConfig prop on Android
#1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovate bot
referenced
this pull request
in valora-inc/wallet
Nov 2, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-screens](https://github.com/software-mansion/react-native-screens) | [`^3.25.0` -> `^3.26.0`](https://renovatebot.com/diffs/npm/react-native-screens/3.25.0/3.26.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>software-mansion/react-native-screens (react-native-screens)</summary> ### [`v3.26.0`](https://github.com/software-mansion/react-native-screens/releases/tag/3.26.0) [Compare Source](https://github.com/software-mansion/react-native-screens/compare/3.25.0...3.26.0) Minor release adding new useAnimatedHeaderHeight and useReanimatedHeaderHeight hooks, providing fixes for search bar and introducing internal changes. *Please note that new hooks introduced in this release are fully functional on Paper, on Fabric there are few edge cases we are still working on*. #### What's Changed #### 🐛 Bug fixes - Change implementation of `headerConfig` prop on Android by [@​tboba](https://github.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1883](https://github.com/software-mansion/react-native-screens/pull/1883) - Change elements visibility on search bar open by [@​tboba](https://github.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1903](https://github.com/software-mansion/react-native-screens/pull/1903) - Fix positioning of large header and search bar by [@​tboba](https://github.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1895](https://github.com/software-mansion/react-native-screens/pull/1895) - Change implementation of calculating status bar, refactor methods used on header height change by [@​tboba](https://github.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1917](https://github.com/software-mansion/react-native-screens/pull/1917) - Fix calculating header height when changing status/action bar visibility by [@​tboba](https://github.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1922](https://github.com/software-mansion/react-native-screens/pull/1922) - Allow Reanimated Screen to check large header by [@​tboba](https://github.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1915](https://github.com/software-mansion/react-native-screens/pull/1915) - Fix issue when emptying nav stack on Windows by [@​chrisglein](https://github.com/chrisglein) in [https://github.com/software-mansion/react-native-screens/pull/1890](https://github.com/software-mansion/react-native-screens/pull/1890) - Update podspec to use install_modules_dependencies by [@​cipolleschi](https://github.com/cipolleschi) in [https://github.com/software-mansion/react-native-screens/pull/1920](https://github.com/software-mansion/react-native-screens/pull/1920) - Remove MaxPerm args from JVM invocation by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1888](https://github.com/software-mansion/react-native-screens/pull/1888) #### 👍 Improvements - Calculate values of useHeaderHeight natively by [@​tboba](https://github.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1802](https://github.com/software-mansion/react-native-screens/pull/1802) - Allow for different fragment types inside ScreenContainer by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1887](https://github.com/software-mansion/react-native-screens/pull/1887) - Add focused states on page transitions by [@​tboba](https://github.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1894](https://github.com/software-mansion/react-native-screens/pull/1894) #### 🔢 Miscellaneous - **Create FUNDING.yml by [@​aleqsio](https://github.com/aleqsio) in [https://github.com/software-mansion/react-native-screens/pull/1886](https://github.com/software-mansion/react-native-screens/pull/1886)** - Migrate from deprecated `RCTEventEmitter` by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1867](https://github.com/software-mansion/react-native-screens/pull/1867) - Use `require` syntax for resolution of all native components by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1909](https://github.com/software-mansion/react-native-screens/pull/1909) - Run Android e2e with JDK 17 by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1892](https://github.com/software-mansion/react-native-screens/pull/1892) - Put timelimit on execution of each workflow by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1893](https://github.com/software-mansion/react-native-screens/pull/1893) - Trigger e2e tests on JS-only changes by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1910](https://github.com/software-mansion/react-native-screens/pull/1910) - Update deprecated expo install instructions to `npx expo install` by [@​GabrieldosSantosOliveira](https://github.com/GabrieldosSantosOliveira) in [https://github.com/software-mansion/react-native-screens/pull/1899](https://github.com/software-mansion/react-native-screens/pull/1899) - Bump activesupport from 6.1.7.3 to 7.0.7.2 in /TestsExample by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-screens/pull/1877](https://github.com/software-mansion/react-native-screens/pull/1877) - Update deps & RN in example apps after release by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1878](https://github.com/software-mansion/react-native-screens/pull/1878) - Migrate `Example` app & e2e tests to RN 0.72.4 by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1880](https://github.com/software-mansion/react-native-screens/pull/1880) - Bump library deps to recent versions (including RN) by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1881](https://github.com/software-mansion/react-native-screens/pull/1881) - Bump library native Android deps & config by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1891](https://github.com/software-mansion/react-native-screens/pull/1891) #### New Contributors - [@​chrisglein](https://github.com/chrisglein) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1890](https://github.com/software-mansion/react-native-screens/pull/1890) - [@​GabrieldosSantosOliveira](https://github.com/GabrieldosSantosOliveira) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1899](https://github.com/software-mansion/react-native-screens/pull/1899) - [@​cipolleschi](https://github.com/cipolleschi) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1920](https://github.com/software-mansion/react-native-screens/pull/1920) **Full Changelog**: software-mansion/react-native-screens@3.25.0...3.26.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com> Co-authored-by: Silas Boyd-Wickizer <silasbw@gmail.com> Co-authored-by: Silas Boyd-Wickizer <silas@valora.xyz>
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
](https://renovatebot.com){kind=link}
…software-mansion#1883) ## Description It looks like the change introduced in software-mansion#1825 has also came with a bug where at least Search Bar was not working on Android. The reason for that has turned out to be the wrong implementation of `headerConfig` property on Android, which was looking for the first child and assuming that it is ScreenStackHeaderConfig - which was wrong, because the change in software-mansion#1825 has moved the ScreenStackHeaderConfig to the bottom of the hierarchy. Fixes not working Search Bar on Android (and some other unknown things maybe?). ## Changes From now `Screen#headerConfig` will traverse through all children of the View and will check if one of them is `ScreenStackHeaderConfig`. ## Test code and steps to reproduce You can check Test1166 if SearchBar is working right now; from now the Search Bar in Example section should work properly. ## Checklist - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It looks like the change introduced in #1825 has also came with a bug where at least Search Bar was not working on Android.
The reason for that has turned out to be the wrong implementation of
headerConfigproperty on Android, which was looking for the first child and assuming that it is ScreenStackHeaderConfig - which was wrong, because the change in #1825 has moved the ScreenStackHeaderConfig to the bottom of the hierarchy.Fixes not working Search Bar on Android (and some other unknown things maybe?).
Changes
From now
Screen#headerConfigwill traverse through all children of the View and will check if one of them isScreenStackHeaderConfig.Test code and steps to reproduce
You can check Test1166 if SearchBar is working right now; from now the Search Bar in Example section should work properly.
Checklist